Error for no abi version #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
noa/no-abi-error
branch
from
3c084a4 to
0bfbecd
Compare
kulakowski
approved these changes
Nov 21, 2023
| @@ -54,4 +48,7 @@ pub enum AbiVersionError { | |||
| got: VersionTuple, | |||
| implements: VersionTuple, | |||
| }, | |||
| // TODO: (by 1.0, maybe) remove the parenthetical from this error message | |||
| #[error("unable to determine ABI of module (may be on an spacetime version < 0.8)")] | |||
There was a problem hiding this comment.
spelling: a spacetime version
There was a problem hiding this comment.
oops, had it on auto-merge. well, it'll get fixed before 1.0 :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
helps with the 0.7 -> 0.8 transition